Test on lowest and highest dependencies #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
reviewed
Jul 27, 2021
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: ready for review
and removed
Progress: review
labels
fredden
reviewed
Jul 27, 2021
m2-community-project
bot
added
Progress: review
Progress: ready for review
and removed
Progress: ready for review
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
Remove experimental flag
sivaschenko
approved these changes
Jul 29, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes running tests on all supported PHP versions (7.2, 7.3, 7.4, 8.0) on the highest and lowest dependency versions to make sure we don't have any issues with dependencies.
Notes:
The phpcs is not compatible with PHPUnit 8 and PHPUnit 9, which is required for PHP 8. But the only latest version works fine with ignoring platform requirements in composer. For now, we're ignoring them for PHP 8.0.
PHP 8 is supported by phpcs 3.6.0. In prev. versions there were, so I'm running PHP 8 with only the highest dependencies
As PHP 8 builds is failing - I added continue on error only for this type of builds, so the entire CI isn't failing (https://github.com/magento/magento-coding-standard/actions/runs/1070813599)
I tested this PR together with Fix TypeError for phpcs->addWarning() #205 - it fixes errors on PHP 8.